wheel builds: react to changes in pip's handling of build constraints#2212
Conversation
jameslamb
left a comment
There was a problem hiding this comment.
Thanks. The deprecation warning is still showing up in librmm builds: https://github.com/rapidsai/rmm/actions/runs/21013612506/job/60414149162?pr=2212#step:13:51
Please modify https://github.com/rapidsai/rmm/blob/main/ci/build_wheel_cpp.sh like this:
- put the
pip wheelarguments into an array (for consistency, let's do this across all of RAPIDS) - add the comment + code with
unset PIP_CONSTRAINT
|
Could you please also update all these PR titles to something a bit more specific, like |
Co-authored-by: James Lamb <jaylamb20@gmail.com>
jameslamb
left a comment
There was a problem hiding this comment.
This is looking great. Seeing lines like this in the rmm build tells us that the constraints are working correctly (the local librmm is being used, not a new one installed from a remote index)
Processing /tmp/tmp.6RmeVFBjVQ/librmm_cu13-26.2.0a52-py3-none-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl
And everything else in rmm and librmm wheel builds looks good.
|
/merge |
…rapidsai#2212) Contributes to rapidsai/build-planning#242 Modifying `ci/build_wheel_python.sh` to avoid passing `--build-constraint` and `--no-build-isolation` together which results in an error from `pip`, however we want to keep environment variable `PIP_CONSTRAINT` set unconditionally. Can be merged after rapidsai/gha-tools#237 Authors: - Mike McCarty (https://github.com/mmccarty) Approvers: - James Lamb (https://github.com/jameslamb) URL: rapidsai#2212
…#2214) #2212 was into `main` after `main` had already been updated to RAPIDS 26.04. This change is intended for RAPIDS 26.02, so this PR backports it to the `release/26.02` branch. ## Notes for Reviewers ### How this should be merged I think normal squash and merge should be fine? The commit SHA is different because of the direction of the `cherry-pick` anyway. ### How I made this branch ```shell git checkout main git pull upstream main git fetch upstream release/26.02 git checkout release/26.02 git checkout -b pip-changes git cherry-pick f380eff ``` Co-authored-by: Mike McCarty <mmccarty@nvidia.com>
Description
Contributes to rapidsai/build-planning#242
Modifying
ci/build_wheel_python.shto avoid passing--build-constraintand--no-build-isolationtogether which results in an error frompip, however we want to keep environment variablePIP_CONSTRAINTset unconditionally.Can be merged after rapidsai/gha-tools#237