Skip to content

wheel builds: react to changes in pip's handling of build constraints#2212

Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom
mmccarty:fix/new-build-constraint
Jan 15, 2026
Merged

wheel builds: react to changes in pip's handling of build constraints#2212
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom
mmccarty:fix/new-build-constraint

Conversation

@mmccarty
Copy link
Contributor

@mmccarty mmccarty commented Jan 14, 2026

Description

Contributes to rapidsai/build-planning#242

Modifying ci/build_wheel_python.sh to avoid passing --build-constraint and --no-build-isolation together which results in an error from pip, however we want to keep environment variable PIP_CONSTRAINT set unconditionally.

Can be merged after rapidsai/gha-tools#237

@mmccarty mmccarty requested a review from jameslamb January 14, 2026 21:27
@mmccarty mmccarty requested a review from a team as a code owner January 14, 2026 21:27
@mmccarty mmccarty added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 14, 2026
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The deprecation warning is still showing up in librmm builds: https://github.com/rapidsai/rmm/actions/runs/21013612506/job/60414149162?pr=2212#step:13:51

Please modify https://github.com/rapidsai/rmm/blob/main/ci/build_wheel_cpp.sh like this:

  • put the pip wheel arguments into an array (for consistency, let's do this across all of RAPIDS)
  • add the comment + code with unset PIP_CONSTRAINT

@jameslamb
Copy link
Member

Could you please also update all these PR titles to something a bit more specific, like "wheel builds: react to changes in pip's handling of build constraints"?

@mmccarty mmccarty changed the title Avoiding conflict with build-constraint and no-build-isolation wheel builds: react to changes in pip's handling of build constraints Jan 15, 2026
mmccarty and others added 2 commits January 15, 2026 14:27
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Seeing lines like this in the rmm build tells us that the constraints are working correctly (the local librmm is being used, not a new one installed from a remote index)

Processing /tmp/tmp.6RmeVFBjVQ/librmm_cu13-26.2.0a52-py3-none-manylinux_2_24_aarch64.manylinux_2_28_aarch64.whl

And everything else in rmm and librmm wheel builds looks good.

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f380eff into rapidsai:main Jan 15, 2026
85 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Jan 15, 2026
jameslamb pushed a commit to jameslamb/rmm that referenced this pull request Jan 15, 2026
…rapidsai#2212)

Contributes to rapidsai/build-planning#242

Modifying `ci/build_wheel_python.sh` to avoid passing `--build-constraint` and `--no-build-isolation` together which results in an error from `pip`, however we want to keep environment variable `PIP_CONSTRAINT` set unconditionally.

Can be merged after rapidsai/gha-tools#237

Authors:
  - Mike McCarty (https://github.com/mmccarty)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: rapidsai#2212
jameslamb added a commit that referenced this pull request Jan 15, 2026
…#2214)

#2212 was into `main` after `main` had already been updated to RAPIDS
26.04.

This change is intended for RAPIDS 26.02, so this PR backports it to the
`release/26.02` branch.

## Notes for Reviewers

### How this should be merged

I think normal squash and merge should be fine? The commit SHA is
different because of the direction of the `cherry-pick` anyway.

### How I made this branch

```shell
git checkout main
git pull upstream main
git fetch upstream release/26.02
git checkout release/26.02
git checkout -b pip-changes
git cherry-pick f380eff
```

Co-authored-by: Mike McCarty <mmccarty@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants